Repository navigation
Fix: make large widgets fill the desktop rows they span - #461
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WIDGET_HEIGHTSfor large and extra large to 330 and 510, two and three 150px rows plus their 30px row gaps, up from 304 and 456..r2, .r3 { align-self: stretch }) and give their cardsheight: 100%with the table value asmin-height, so they end with the row beside them, including rows sized by app tiles.Testing
All green, Docker build and e2e included. Added a test that each multi-row height equals its rows plus the gaps between them.
Changelog
Fixed
Checklist