Repository navigation
Fix: use locale plural rules and whole messages in translations - #463
Merged
Merged
Conversation
Counted strings take the language's CLDR plural category, sentences built from translated fragments become single catalog messages, lists use Intl.ListFormat, Backup ages use Intl.RelativeTimeFormat, and the language picker marks each name with its language.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
=== 1by counted catalog messages:home.resultCount,status.pending, Connectionsui.peerCount/ui.peerRatio/ui.peersOnline, Disk Healthui.baysFailed.wtCount()(counted widget messages viaIntl.PluralRules), avarsargument towt(),relativeTime()and a re-exportedformatList()to the widget toolbox;loadStrings()now also awaits the shared widget strings.formatList()toformat-number.js(Intl.ListFormatin the interface language) and use it in the listbox summary, withheld-secret toast, Disk Health, GitHub filters, Connections map and Backup labels.Intl.RelativeTimeFormatinstead of hand-written English, the card reads "Last {when}" / "Next {when}" as one message, and job states are translated in the label.lang(WCAG 2.2 SC 3.1.2).labelKeyon/api/widget-optionsthrough the widget catalog; System Summary's "All interfaces" uses it.ui.onlineso the map status and the peer count no longer share one string.Testing
All green, Docker build and e2e included. Added tests for widget plurals, list and relative-time formatting, option labels, the language picker, and a guard against
=== 1plurals and glued translated text.Changelog
Fixed
Checklist