Repository navigation
Fix: weather card edges in daylight and uneven System Summary column gaps - #466
Merged
Merged
Conversation
- Mark a widget card light when the widget paints a light background, and give it the light card tokens in the dark theme. - Space chart columns with transparent inline borders instead of flex gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setCardAppearance(false)setsdata-appearance="light"on the card instead of clearing it.data-appearance="light"(white background, light-theme border and edges), so a card wider than its contain-fitted widget shows white at the sides behind the daytime Weather face.gapincolumns()with transparent inline borders,background-clip: padding-boxand a negative container margin, so gaps stay equal under fractional widget zoom.Testing
All green. Added a test for the column border spacing and updated the card appearance test.
Changelog
Fixed
Checklist