Repository navigation
Fix: Backup text in right-to-left layout and short spines on large Books - #469
Merged
Merged
Conversation
… spines - Backup: anchor the canvas text at its left edge, so right-to-left lines no longer run past the card. - Books: on the three-shelf card, books stand 90 to 99% of the shelf, so spines show more of each title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctx.textAlign = 'left'before drawing the canvas text lines. Underdir=rtlthe defaultstartalignment anchored each line at its right end, so Persian lines ran past the card's left edge.Testing
All green, including the Docker build and e2e. Added tests for the canvas text alignment and the book heights per shelf count.
Changelog
Fixed
Checklist