Repository navigation
Improve: serve community icons through the API with an in-memory cache - #47
Merged
Merged
Conversation
Icon files were fetched by the browser from jsDelivr on every page load, which told the CDN which services a dashboard shows and left the dashboard without icons when it was unreachable. Add GET /api/icons/cdn, which fetches an icon once, sanitises SVG, and holds it in memory for a day. Nothing is written to disk. The direct CDN URL stays in the icon chain as a fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/icons/cdn, which fetches an icon from the dashboard-icons catalogue once and holds the bytes in memory for 24 hours, bounded to 300 entries and 512 KB per file.X-Content-Type-Options: nosniff; a body that is not the declared image type is treated as missing.binaryoption tofetchJSONthat resolves the rawBufferand content type, so image bytes are not corrupted by the utf8 conversion.iconChain, keeping the CDN links as the fallback.Testing
All green, apart from the Docker build smoke test, which needs a local Docker daemon. Added 8 route tests covering the single outbound fetch, the negative cache, refused names, SVG sanitising and PNG sniffing, and updated the icon-chain tests.
Checklist