Skip to content

Fix: use the shared Persian label for the VPN link field #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SandObserver merged 1 commit into from
Oct 17, 2026
Merged

Fix: use the shared Persian label for the VPN link field #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions api/test/widget-catalogs.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,3 +96,18 @@ for (const widget of widgets.filter(hasCatalog)) {
}
});
}

const LINK_LABEL = /(^|\.)[A-Za-z]*[hH]ref\.label$/;
const OPTIONAL = /\s*[(（][^)）]*[)）]$/;

test('every link field in a language has the same label', () => {
for (const lang of LANGUAGES) {
const labels = new Set();
for (const w of widgets.filter(hasCatalog)) {
for (const [key, value] of Object.entries(readCatalog(w, lang))) {
if (LINK_LABEL.test(key)) labels.add(value.replace(OPTIONAL, ''));
}
}
assert.equal(labels.size, 1, `${lang}: ${[...labels].join(' | ')}`);
}
});
2 changes: 1 addition & 1 deletion ui/widgets/connections/i18n/fa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"vpn.url.placeholder.netbird": "http://netbird:33073",
"vpn.apiKey.label": "کلید API",
"vpn.token.label": "توکن دسترسی (PAT)",
"vpn.href.label": "آدرس کلیک",
"vpn.href.label": "آدرس پیوند",
"vpn.href.placeholder": "http://your-server:8000",
"vpn.showIp.label": "نمایش آدرس IP",
"vpn.showIp.hint": "برای هر کسی که داشبورد را می‌بیند نمایان است. وقتی تونل قطع است، این آدرس خانه شماست.",
Expand Down
Loading