Repository navigation
Fix: join lists without a conjunction in the interface language - #478
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unitlist type informatListwithplain: a narrow conjunction list. CLDR's Chinese unit pattern joins items with nothing, which ran screen-reader labels together.formatList(..., 'plain')for the GitHub pull request filter label, the Connections map spoken lists and legend overflow title, and the System Summary screen-reader summary, in place of hard-coded commas or unit lists.Testing
All green, e2e included. Added 2 tests.
Changelog
Checklist