Skip to content

Fix: open a widget link once when the widget has its own click handler - #479

Merged
SandObserver merged 1 commit into
mainfrom
fix/widget-link-opens-once
Oct 17, 2026
Merged

SandObserver merged 1 commit into
mainfrom
fix/widget-link-opens-once

Conversation

@SandObserver

Copy link
Copy Markdown
Owner

Summary

  • openUrl stops propagation of the click on its temporary anchor. A body-level click handler, such as System Summary's, otherwise called openUrl again for that click, recursing until Chromium gave up; with the popup blocker on, no tab opened.
  • System Summary's body click handler skips #ss-link, which linkTo already handles, so an assistive-technology activation opens one tab instead of two.

Testing
All green, e2e included. Added 2 tests.

Changelog

Checklist

  • Stays within the project constraints: one container, no runtime dependencies, no build step (see CONTRIBUTING.md).
  • Tests added or updated for new logic, and the full suite, lint, and typechecks pass.
  • Docs updated if behavior or configuration changed.

@SandObserver SandObserver added the bug Something isn't working label Oct 17, 2026
@SandObserver
SandObserver merged commit f41315a into main Oct 17, 2026
6 checks passed
@SandObserver
SandObserver deleted the fix/widget-link-opens-once branch October 17, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant