Skip to content

Fix: treat trailing-dot and IPv4-mapped loopback hosts as unreachable #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SandObserver merged 1 commit into from
Oct 17, 2026
Merged

Fix: treat trailing-dot and IPv4-mapped loopback hosts as unreachable #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ui/js/service-link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,14 @@ export function browserLink(raw) {
return '';
}
if (u.protocol !== 'http:' && u.protocol !== 'https:') return '';
const host = u.hostname.toLowerCase().replace(/^\[|\]$/g, '');
const host = u.hostname
.toLowerCase()
.replace(/^\[|\]$/g, '')
.replace(/\.$/, '');
if (host === 'localhost' || host.endsWith('.localhost') || host === 'host.docker.internal') return '';
if (host === '::1' || host === '0.0.0.0' || /^127\./.test(host)) return '';
if (host === '::1' || host === '::' || host === '0.0.0.0' || /^127\./.test(host)) return '';
const mapped = /^::ffff:([0-9a-f]{1,4}):[0-9a-f]{1,4}$/.exec(host);
if (mapped && [0, 127].includes(parseInt(mapped[1], 16) >> 8)) return '';
if (!host.includes('.') && !host.includes(':')) return '';
u.username = '';
u.password = '';
Expand Down
5 changes: 5 additions & 0 deletions ui/test/service-link.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ test('an address only the server can reach gives no link', () => {
'http://127.0.0.1:3000',
'http://[::1]:80',
'http://host.docker.internal:9000',
'http://localhost.:8080',
'http://foo.localhost.',
'http://[::ffff:127.0.0.1]:8080',
'http://[::ffff:0.0.0.0]',
'http://[::]:80',
'',
null,
'ftp://10.0.0.1',
Expand Down
Loading