Repository navigation
Security: stop trusting the first host name while no password is set - #485
Merged
Merged
Conversation
The API no longer stores the Host of the first GET /api/auth/check as an allowed address. A rebound page could send that request before the owner, register its own name and then set the password. Names are added only in Settings, from an IP address or a local name. Remove the dashboard boot retry for requests refused before that check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refusedHostthat saved the Host of the firstGET /api/auth/checkintosettings.server.allowedHosts. With no password set, only local addresses and names already in the list are answered.refusedHostand its call in the router./api/config,/api/widgetsand/api/icons/localafter a 403, which only covered requests sent before the first-visit step.Testing
All green, including e2e. Replaced the first-visit tests with a rebound page that loads first and an owner adding a name from an IP address.
Changelog
Security
Checklist