Skip to content

Fix: show Backup haikus only when every line fits - #487

Merged
SandObserver merged 1 commit into
mainfrom
fix/backup-haiku-fit
Oct 18, 2026
Merged

SandObserver merged 1 commit into
mainfrom
fix/backup-haiku-fit

Conversation

@SandObserver

Copy link
Copy Markdown
Owner

Summary

  • Add pickHaiku to the Backup widget: each card draws the first shuffled haiku whose lines all fit the card width and height, or plain rows when none fits.
  • Remove the per-line fallback that drew an over-wide line as a plain row and left a partial haiku.
  • Drop one-line haikus from the pool and split "Keep it safe." into two lines in every locale.
  • Add nine short two-line haikus to ui.haikus in en, de, es, fr, fa and zh-Hans, and to the English fallback.

Testing
All green. Added 4 tests for haiku selection.

Changelog

Fixed

  • Backup cards show a whole haiku or none, never part of one.

Added

  • Nine short Backup haikus that fit small cards.

Checklist

  • Stays within the project constraints: one container, no runtime dependencies, no build step (see CONTRIBUTING.md).
  • Tests added or updated for new logic, and the full suite, lint, and typechecks pass.
  • Docs updated if behavior or configuration changed.

Pick the first shuffled haiku whose lines all fit the card width and height
instead of replacing lines that do not fit with plain rows. Require at least
two lines. Add nine short haikus in every locale and split the one-line haiku.
@SandObserver SandObserver added the bug Something isn't working label Oct 18, 2026
@SandObserver
SandObserver merged commit 36161fd into main Oct 18, 2026
6 checks passed
@SandObserver
SandObserver deleted the fix/backup-haiku-fit branch October 18, 2026 00:51
stackyard-release Bot pushed a commit that referenced this pull request Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant