Repository navigation
Fix: show Backup haikus only when every line fits - #487
Merged
Merged
Conversation
Pick the first shuffled haiku whose lines all fit the card width and height instead of replacing lines that do not fit with plain rows. Require at least two lines. Add nine short haikus in every locale and split the one-line haiku.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pickHaikuto the Backup widget: each card draws the first shuffled haiku whose lines all fit the card width and height, or plain rows when none fits.ui.haikusin en, de, es, fr, fa and zh-Hans, and to the English fallback.Testing
All green. Added 4 tests for haiku selection.
Changelog
Fixed
Added
Checklist