Repository navigation
Security: refuse a non-object settings block on save and on read - #495
Merged
Merged
Conversation
A config save with settings as an array or a primitive dropped the stored password when written. A file with such a settings block loaded as an open install and was overwritten on the next save. Both now count as invalid: the save returns 400, and the file is backed up and marked damaged. Item entries that are not objects are skipped on read after the file is backed up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/configwhensettingsis present and is not a plain object. An array or primitive previously lost the preservedsettings.authon write, which removed the password without the current-password check.settingsvalue inapps.jsonthat is not a plain object (array, primitive, null) as wrong shape: back the file up, mark it damaged, refuse sign-in and saving.itemsentries that are not objects on read, after writing a.corrupt-backup of the file. Readers no longer return 500 on a null entry.Testing
All green. Added 6 tests covering the save route and wrong-typed settings and items on disk; all fail without the change.
Changelog
Security
Fixed
Checklist