Repository navigation
Security: refuse deeply nested config saves and clone before writing - #496
Merged
Merged
Conversation
A config value nested thousands of levels deep was written to disk, then failed the in-memory clone. Every later read cloned it too, so Settings, export and sign-in failed until the file was edited by hand. POST /api/config now refuses input nested deeper than 32 levels. saveConfig clones before writing, so a value it cannot clone fails before the file is replaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/configwhen the body nests deeper than 32 levels. Real configs nest at most 6.saveConfigbefore the temp-file write instead of after the rename, so a valuestructuredClonerejects fails beforeapps.jsonis replaced.Testing
All green. Added 3 tests: a too-deep save is refused with the file unchanged, a realistic depth is accepted, and an unclonable value leaves the file and no temp file.
Changelog
Security
Checklist