Repository navigation
Fix: count import changes against the server's export - #498
Merged
Merged
Conversation
The import dialog compared the file with the editor's in-memory items, which keep row key order and secret values the export does not, so an unchanged export reported updated items. The export also left out the Settings system item, so a fresh install's export reported one deletion. The dialog now compares the file with a fresh export using a key-order independent comparison, and the export includes the system items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
importCountstoadmin-save-logic.js: added, updated and deleted counts with a key-order independent comparison.GET /api/config/exportinstead ofstate.items.ensureSystemItemsonGET /api/config/export, so the export lists the same items asGET /api/config.Testing
All green, e2e included. Added 2 tests for
importCountsand 1 for export and config item parity.Changelog
Fixed
Checklist