Repository navigation
Fix: never overwrite an existing icon on upload - #499
Merged
Merged
Conversation
safeIconName stopped at the -999 suffix without checking it, so once a name had 999 numbered copies the next upload overwrote the last one. It now falls back to a random suffix, and the upload writes with the exclusive-create flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safeIconNamewhen the name and all 998 numbered copies exist.wxflag, so an existing file is never truncated.Testing
All green. Added 1 test for the exhausted-suffix case.
Changelog
Fixed
Checklist