Repository navigation
Security: stop allowing Google Fonts in the content security policies - #50
Merged
Merged
Conversation
The default policy and the widget policy permitted fonts.googleapis.com and fonts.gstatic.com, left from a widget that no longer exists. The stylesheets use system fonts and the image ships its own assets, so nothing requests either host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://fonts.googleapis.comfromstyle-srcandhttps://fonts.gstatic.comfromfont-srcinnginx/csp-default.confand in the widget policy innginx/dashboard.conf.csp-default.confthat described/adminas the policy without Google Fonts, which no longer distinguishes it.font-srcorstyle-src.Testing
All green, apart from the Docker build smoke test, which needs a local Docker daemon. Added 1 test covering every policy in the config; verified it fails against the previous policy text rather than passing vacuously.
Checklist