Repository navigation
Security: keep the stored Unsplash key when the wallpaper is saved - #500
Merged
Merged
Conversation
Open the API key field empty as a password input and send the key only when one is typed. Opening the field and saving no longer replaces the stored key with the row's label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autocomplete="new-password", instead of copying the row label into it.saveWallpaperonly when one was typed, then clear the input and show the row as configured./api/settings/unsplash-keyand remove the unused#bg-apikeyinput from the admin page.Testing
All green. Added 2 e2e tests: opening and saving sends no key, and a typed key is sent once.
Changelog
Security
Checklist