Repository navigation
Security: load every catalogue icon through the server - #501
Merged
Merged
Conversation
Drop the direct CDN fallbacks from the icon chain, route saved CDN links and icon picker results through /api/icons/cdn, and set connect-src 'self' in both page policies. The demo still loads icons from the CDN directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iconChain: a name resolves to its local copy, then one/api/icons/cdnrequest.throughServer, which maps catalogue CDN URLs to the proxy, and use it for saved icon links and icon picker results.connect-src 'self'in the default and admin policies. Keep theimg-srcCDN allowance for demo mode, which loads icons directly.Testing
All green. Added unit tests for the chain and proxy mapping, an nginx policy test, and an e2e test that the dashboard and Settings make no CDN request.
Changelog
Security
Checklist