Skip to content

Security: count sign-in attempts from unlisted host names separately - #503

Merged
SandObserver merged 1 commit into
mainfrom
security/login-limit-unknown-hosts
Oct 19, 2026
Merged

SandObserver merged 1 commit into
mainfrom
security/login-limit-unknown-hosts

Conversation

@SandObserver

Copy link
Copy Markdown
Owner

Summary

  • Add knownHost to host-check.js (local name or listed in allowedHosts) and reuse it in refusedHost.
  • Key failed sign-in attempts on the client IP plus an unlisted marker when the Host header is not known, in login, set-password and clear.

Testing
All green. Added 3 tests for the separate counters.

Changelog

Security

  • A page on another site can no longer lock the owner out of sign-in by pointing its host name at the server.

Checklist

  • Stays within the project constraints: one container, no runtime dependencies, no build step (see CONTRIBUTING.md).
  • Tests added or updated for new logic, and the full suite, lint, and typechecks pass.
  • Docs updated if behavior or configuration changed.

Attempts sent under a host name that is neither local nor in the allowed list use their own counter, so a rebound name cannot lock out the owner's sign-in.
@SandObserver SandObserver added the security Security fix label Oct 19, 2026
@SandObserver
SandObserver merged commit b9eebe4 into main Oct 19, 2026
6 checks passed
@SandObserver
SandObserver deleted the security/login-limit-unknown-hosts branch October 19, 2026 02:22
stackyard-release Bot pushed a commit that referenced this pull request Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security Security fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant