Skip to content

Security: accept any valid session cookie and hide blocked addresses - #505

Merged
SandObserver merged 1 commit into
mainfrom
security/guard-message-and-cookie
Oct 19, 2026
Merged

SandObserver merged 1 commit into
mainfrom
security/guard-message-and-cookie

Conversation

@SandObserver

Copy link
Copy Markdown
Owner

Summary

  • Replace parseCookies with sessionTokens, which returns every ds value, and accept the first valid, unrevoked one in readSession.
  • Return a fixed sentence from the Connections widget when the address guard blocks a request.

Testing
All green. Added tests for a shadowing cookie and the blocked-address reply.

Changelog

Security

  • A session cookie set by another host on the same parent domain no longer signs the owner out.
  • The Connections widget no longer names an address the guard blocked.

Checklist

  • Stays within the project constraints: one container, no runtime dependencies, no build step (see CONTRIBUTING.md).
  • Tests added or updated for new logic, and the full suite, lint, and typechecks pass.
  • Docs updated if behavior or configuration changed.

Read every ds cookie and accept the first valid one, so a cookie set by a sibling host on the parent domain no longer hides the session. The Connections widget returns a fixed sentence when the address guard blocks a request.
@SandObserver SandObserver added the security Security fix label Oct 19, 2026
@SandObserver
SandObserver merged commit c09e1c7 into main Oct 19, 2026
6 checks passed
@SandObserver
SandObserver deleted the security/guard-message-and-cookie branch October 19, 2026 02:36
stackyard-release Bot pushed a commit that referenced this pull request Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security Security fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant