Repository navigation
Security: accept any valid session cookie and hide blocked addresses - #505
Merged
Merged
Conversation
Read every ds cookie and accept the first valid one, so a cookie set by a sibling host on the parent domain no longer hides the session. The Connections widget returns a fixed sentence when the address guard blocks a request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseCookieswithsessionTokens, which returns everydsvalue, and accept the first valid, unrevoked one inreadSession.Testing
All green. Added tests for a shadowing cookie and the blocked-address reply.
Changelog
Security
Checklist