Repository navigation
Add: browser tests for the dashboard - #51
Merged
Merged
Conversation
The end-to-end suite drove Admin only, so nothing opened the dashboard in a browser. Cover the four things only a browser proves: items become tiles with their label and link, a badge value paints and is replaced on the next poll, a failed item keeps its value marked stale, search opens on a keypress and filters, and a widget renders inside its frame under the page's Content-Security-Policy.
The prompt covers the dashboard and the tiles are never built behind it, so every dashboard spec found no tiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e/dashboard.spec.jscovering tile rendering with label, href andrel=noopener; badge painting and replacement on the next poll; a failed item keeping its last value with the stale marking; search opening on a printable keypress, filtering, and closing on Escape; and a clock widget drawing inside its iframe./api/badgesand/api/healthper spec so nothing waits onexample.invalid, and force the follow-up poll through the visibility handler rather than the twenty-second interval.seedConfigandapphelpers; no new helpers.playwright.config.jsheader, which described the suite as admin-only.Testing
Unit suites, lint, format and typechecks all green. The specs themselves run in the e2e check on this pull request: Playwright's browsers cannot run on the machine this was written on, so CI is their first execution. Both seeded fixtures were validated against a real API instance first, so a rejected seed cannot be the reason for a failure.
Checklist