Repository navigation
Fix: limit widget data cache keys to declared query values - #510
Merged
Merged
Conversation
Build the widget-data cache key and ctx.params from the endpoint and the names a widget manifest lists in a new params field. Cap cached replies at 16 per widget. System Summary declares seed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/widget-datacache key andctx.paramsfromendpointplus the names the widget manifest lists in a newparamsfield. Other query values are dropped.paramsin the manifest: at most 8 query parameter names, no duplicates,endpointnot listed.latest(), dropping the oldest settled entries and never a refresh in flight.seedin the System Summary manifest.Testing
All green. Added tests for the parameter filter, manifest validation, the per-widget cap, junk query values sharing one refresh, and a guard that every value a
data.jsreads is declared.Changelog
Added
Fixed
Checklist