Repository navigation
Fix: pause widget animations off screen and stop VPN loop stacking - #512
Merged
Merged
Conversation
Add whileOnScreen to the widget toolbox and gate the Connections map and VPN animation loops on it. Track the VPN frame id so each render keeps one loop. Keep the Analog clock stopped on tab return while it is off screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whileOnScreen(el, onChange)to the widget toolbox: reports whether an element intersects the viewport in a visible tab, throughIntersectionObserverandvisibilitychange.visibilitychangewhile its face is off screen.Testing
All green. Added tests for
whileOnScreenand for the map pausing off screen and resuming on return.Changelog
Fixed
Checklist