Repository navigation
Fix: log a failing widget once instead of on every request - #513
Merged
Merged
Conversation
Track widget-data failures per widget and endpoint. Log the first failure, a changed reason, a reminder every 10 minutes with the failure count, and one line on recovery. Stop fail() logging the same failure a second time for widget-data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api/src/failure-log.js: tracks failures per key and logs the first failure, a changed reason, a reminder every 10 minutes with the failure count and start time, and one info line on recovery. Entries untouched for an hour are dropped.quietoption tofail()and use it for widget-data, so a cached failure served to each tab is not logged again.Testing
All green. Added unit tests for the tracker and an integration test that five failed requests log one line.
Changelog
Changed
Checklist