Skip to content

Fix: show a widget render failure as an internal error - #518

Merged
SandObserver merged 1 commit into
mainfrom
fix/render-error-kind
Oct 19, 2026
Merged

SandObserver merged 1 commit into
mainfrom
fix/render-error-kind

Conversation

@SandObserver

Copy link
Copy Markdown
Owner

Summary

  • In poll(), tag an error thrown after a successful fetch (by render, isEmpty or onEmpty) with kind internal, so the error state reads "Something went wrong" instead of "Out of reach".
  • Keep an existing kind on the thrown error, and wrap a frozen or non-object throw in an Error.
  • Refresh cache-busting stamps for widget-toolbox.js.

Testing
All green. Added a test that a render failure maps to internal and a fetch failure to network.

Changelog

Checklist

  • Stays within the project constraints: one container, no runtime dependencies, no build step (see CONTRIBUTING.md).
  • Tests added or updated for new logic, and the full suite, lint, and typechecks pass.
  • Docs updated if behavior or configuration changed.

@SandObserver SandObserver added the bug Something isn't working label Oct 19, 2026
@SandObserver
SandObserver merged commit 8e81a58 into main Oct 19, 2026
6 checks passed
@SandObserver
SandObserver deleted the fix/render-error-kind branch October 19, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant