Repository navigation
Fix: keep stored secrets per row when group rows change - #519
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
savedRow(the row's index in the saved config, ornullfor a new row) on every row of a group that holds a secret field. The name lives in the new import-freeui/js/saved-row.js, shared by the editor and the API.alignSavedConfig(): when every field outside the secret-holding groups matches the saved config, pair each posted row with the saved row it names, and refill that row's secrets only when its own non-secret, non-cosmetic, non-transient fields match. Rows withoutsavedRowfall back to id, then position.preserveAllSecrets) and forPOST /api/widget-options/:id. A row whose destination changed is still withheld and reported.savedRowinstripWidgetSecretsandpreserveWidgetSecrets, so it is never stored and an unchanged save still matches.<key>Setmarker in the editor through adding and removing rows, so untouched rows show "Configured".saved-row.jsinto the API image and map it intsconfig.frontend.json.Testing
All green, e2e included. Added unit tests for row alignment and config saves, and an e2e test that removes a Connections service and keeps the other's token.
Changelog
Fixed
Checklist