Repository navigation
Fix: honour reduced motion in the toolkit progress bar - #52
Merged
Merged
Conversation
barFill sets its transition as an inline style. A widget page loads no shared stylesheet, and a rule in the page's own <style> cannot override an inline style, so the preference could not reach it. Read the preference in the helper instead. sparkline animates nothing and is left alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prefers-reduced-motioninwidget-toolbox.jsand omit the width transitionbarFillsets inline when it is asked for.matchMediaas no preference, so the bar still draws.barFillentry indocs/widgets.md.sparklineunchanged: it builds a static SVG and animates nothing.Note on scope. No shipped widget imports
barFillorsparkline; every widget draws its own bars and charts, and all thirteen widget pages already carry their ownprefers-reduced-motionblocks. These two helpers are documented toolkit API for the next widget to reuse, which is why this is fixed in the helper rather than left to each page.Testing
All green, apart from the Docker build smoke test, which needs a local Docker daemon. Added 5 tests covering both preference states, the preference being read per call, and a browser with no usable
matchMedia.Checklist