Repository navigation
Fix: date widget readings by when the service produced them - #522
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
latest()outcome with the time it settled (at), and use it as the entry time.Ageheader (whole seconds since the outcome settled) on successfulGET /api/widget-data/:idreplies, so a stored result served during a slow refresh states its real age.readingTime(data)to the widget toolbox:fetchDatarecordsnow - Ageper returned object; anything else reads as now.widget-toolbox.js.Testing
All green. Added tests for the settle time, the
Ageheader on a stored reply,readingTime, and Weather's use of it.Changelog
Checklist