Repository navigation
Fix: fit the colour pickers on narrow phones - #526
Merged
Merged
Conversation
Put each colour row's label above its swatches in the phone layout, size the swatch grid tracks to the 34px touch swatches, and let the HSB sliders shrink below their intrinsic width. Add a 320px reflow test for the icon colour picker in French and Persian.
Lay the HSB slider rows out on a subgrid of the tune area, so the label column takes the longest label and every slider gets the same remaining width. Labels no longer shrink to make room for a slider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.cc-rowin the phone layout so the label takes its own line and the swatches fill a 7-column grid spread across the row..cc-swgrid tracks to the 34px coarse-pointer swatches; they were 26px, so adjacent swatches overlapped and the last one overflowed the row..hsb-rangemin-width:0so the HSB sliders shrink at 320px instead of pushing their end icons out of the row.Testing
All green, including the full e2e suite. Added a 320px reflow test for the icon colour picker in French and Persian, which fails on the previous styles, and a test that the three sliders share one length.
Changelog
Fixed
Checklist