Repository navigation
Fix: give demo widget pages their own stamps so cached pages are not reused - #527
Merged
Merged
Conversation
The image serves stamped widget pages as immutable for a year. The static demo changes those pages, so a browser that had visited the image kept the cached pages without the replay script and every widget request failed. The build now restamps each widget page in the recorded widget list, and verification fails when a widget page keeps the image's address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/widgetsanswer (entryVersions) with a hash of its content, so the static demo serves widget pages at addresses the image never used.Testing
All green. Added 2 tests for restamping; with one browser profile, the image then the current build gave 10 widget API 404s, and the image then this build gave none.
Changelog
Checklist