Repository navigation
Fix: explain that icon search is off in the live demo - #531
Merged
Merged
Conversation
The icon catalogues are fetched from outside, which demo mode blocks, so a search failed with a generic error. Demo mode now answers icon search with the blocked.demo refusal, and the admin explains that icon search is off in the live demo.
SandObserver
force-pushed
the
fix/demo-icon-search-refusal
branch
from
October 20, 2026 21:49
101689e to
9b2eff5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/icons/searchin demo mode with 403 and codeblocked.demoinstead of a 502 from the unreachable catalogues.app.iconSearchDemoin the icon field for that code, without the upload hint, and announce it.app.iconSearchDemoto all six catalogs; update the icon picker tests to the new failure branch.Testing
All green. Added 1 API test, which fails against the previous route.
Changelog
Checklist