Repository navigation
Feature: group the dashboard list into dock and home screen - #540
Merged
Merged
Conversation
Docked apps are listed in their own Dock group above the Home screen group. Rows can be dragged into, out of and within the dock; a full dock refuses a fifth app, and widgets and folders never join it. The Settings tile gets an editor with Show Settings on dashboard and Show in Dock.
- Remove a dropped app from every folder before it joins one. - Skip docked folder children in the folder move arrows and the app count. - Take docked apps out of folders and hidden apps out of the dock on every list save. - Turn off and lock Show in Dock while the Settings tile is hidden, with a note. - Open the admin from a docked Settings tile in the phone layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
n/4count and an empty drop target) and a Home screen group. Show the Dock pill only while filtering.listGroupandcanDropInGroupto the drag logic.applyDroptakes a target group and setsdockon the moved app, refusing non-apps and a full dock.draggingframe ondragend.topLevelRows.list.dockTip,list.dockEmptyandgeneral.dockNeedsShownin all locales. Remove the unusedcommon.show,common.hideandgeneral.hideSettingsAria.Testing
All green, including the full e2e suite. Added drag-logic, reorder and dock-settling unit tests,
e2e/dock-list.spec.js(15 tests) and a dashboard test for the docked Settings link.Changelog
Added
Checklist