Repository navigation
Feature: Proxmox health checks and System Summary source - #543
Merged
Merged
Conversation
Add a Proxmox health check type that reads whether a VM or LXC guest is running, and a Proxmox source for the System Summary widget. Replace the Docker health checks switch with one Health Checks switch in General that gates every check type.
Open
4 of 5 tasks
- Return the Proxmox root filesystem under mount "/" so the System Summary disk slot finds it. - Clear the Proxmox secret field before General records its saved state. - Send a code with Proxmox health errors and show the translated sentence on the tile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api/src/proxmox.js: Proxmox VE API client withPVEAPITokenauth, token ID and secret validation before the header is built, and coded errors for refused tokens, missing permissions and non-Proxmox replies./api/healthreads every guest from one shared/cluster/resources?type=vmrequest, ignores templates, and reports a running, stopped, missing orunknown(no current stats) guest.POST /api/proxmox/test(guest count) andGET /api/proxmox/guests(guest picker), with a demo-mode list.settings.server.proxmox. The secret is scrubbed from config responses and exports, and is restored on save only while address, token ID and certificate setting are unchanged; otherwise it is reported as withheld.settings.server.healthChecks, which gates Ping, Container and Proxmox checks and reveals Hide Healthy Badge, Docker Socket URL and the Proxmox connection. Absent counts as on, so existing configs keep their badges.Testing
All green, including e2e and against a live Proxmox VE 9.2.2. Added 39 tests for the API client, health route, secret handling, widget source and badge reasons.
Changelog
Added
Changed
Checklist