Repository navigation
Fix: settings touch states, text fields and drag feedback - #558
Merged
Merged
Conversation
- Hold a list redraw requested during a drag until the drag ends. - End a touch drag cleanly when it loses pointer capture or its handle leaves the page. - Never settle the floating row onto itself after a drop into a collapsed folder. - Add :active press states to every tappable Settings control. - Let a widget field declare "plain": true; mark the System Summary disk name fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:hoverrules behind(hover:hover) and (pointer:fine), set a transparent tap highlight onhtml, and give every tappable Settings control an:activestate (fill, or opacity for filled and text-only controls).autocapitalize="none" autocorrect="off" spellcheck="false"to address, host, username, token and header fields, to widget text fields whose key ends in url, href, user, username, id or profile, and to manifest fields marked"plain": true. Mark the System Summary disk name fields plain.min-width:0,overflow-wrap:anywhere) so Delete and Save stay on screen for long unbroken names..rmt-url) in right-to-left pages.transform, lift it on touch only after 8px of movement, glide it into its new row (or back on a refused drop) over--t-reveal, and redraw the list before the save returns on a touch drop.lostpointercaptureor when its handle leaves the page; never settle the floating row onto itself.transformonly, on the reveal curve.Testing
All green, including e2e. Added tests for hover gating, press states on every tappable control, field sizes and input attributes, plain manifest fields, drag hysteresis, settle, held redraws and lost capture, chevron rotation, menu and dialog entrance.
Changelog
Added
"plain": true.Changed
Fixed
Checklist