Repository navigation
Fix: cap the desktop grid scale at the design size - #56
Merged
Merged
Conversation
Above the design width the grid, gaps and tile height grew with the viewport, enlarging icons, labels and widget cards past the sizes every desktop layout value was drawn against. Cap each grid custom property at its design value, so the proportional system only scales down for narrower viewports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--grid-w,--col-gap,--row-gapand--tile-hat their design values (1041px, 25px, 30px, 152px) so the desktop grid scales down for narrow viewports only.gridMetrics()still resolves a scale of 1 at and above the design width.[Unreleased]entry to state that sizes above the design width are unchanged.Testing
All green. No new coverage; the change is a stylesheet bound, and the existing pagination and widget-teardown specs read the metrics back through the probe. Docker build smoke test left to CI.
Checklist