Repository navigation
Fix: phone layout on sideways and large screens - #560
Merged
Merged
Conversation
Keep the phone home screen on a phone held sideways, scale it by height, size the Dock to its icons and keep square cells on layouts wider than a phone. Keep the Settings sidebar on short landscape and large screens. Stop iOS Safari from enlarging widget text in landscape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isMobileLayout(true)also matchesiPhone|iPod|Android.*Mobile, so Android tablets keep the desktop layout.BASE_VH), and stop scaling above the widest phone (430) so wider layouts get more cells instead of larger ones.dockFit), keeping the icon-to-Dock ratio of a full-size phone; the search pill follows the Dock height.max-height:500px) and on screens at least 600 wide with a window at least 600 wide; the sidebar is 200px below 769. The preload script mirrors the rule.-webkit-text-size-adjust:100%inwidget-theme.js, so iOS Safari no longer enlarges widget text in landscape.Testing
All green, including e2e on Chromium and WebKit. Added tests for the sideways rules, height scaling, square cells, Dock sizing and widget text sizing.
Changelog
Fixed
Checklist