Repository navigation
Chore: stop a Docker Hub description failure failing the release - #57
Merged
Merged
Conversation
The description update sat between the SBOM generation and its upload, so a rejection from Docker Hub skipped the upload and marked a release whose image was already built, pushed and signed as failed. Move the SBOM upload ahead of both description steps and let the update continue on error.
SandObserver
added
the
github_actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upload SBOMstep ahead of both Docker Hub description steps, so the artifact is uploaded before anything that talks to the Hub API.continue-on-error: trueonUpdate the Docker Hub description, leaving the generation step a hard failure.Testing
All green. No new coverage; the change is workflow step ordering, and
scripts/dockerhub-description.jsis unchanged and already covered.Checklist