Repository navigation
Fix: keep content clear of the notch under Safari page zoom - #579
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui/js/page-zoom.js, a blocking classic script on both pages. It sets--inset-scaleon the root to1 / visualViewport.scale, read only when the layout width changes, so a pinch does not move the insets.--safe-top,--safe-right,--safe-bottomand--safe-lefttotokens.css, eachenv(safe-area-inset-*)times--inset-scale.env(safe-area-inset-*)in the dashboard, Settings and config recovery stylesheets.Testing
All green. Checked on an iPhone in Safari at 50% and 100% page zoom: the side insets measured 118 px and 59 px. Added tests for the scale at 50%, 100% and 150%, a pinch, a later zoom change, the load order, and that only the tokens read the insets.
Changelog
Fixed
Checklist