Repository navigation
Fix: hold a long admin toast long enough to read - #58
Merged
Merged
Conversation
Every toast hid after three seconds, so a multi-line error such as a refused socket proxy address left the screen before it could be read, with no way to bring it back. Derive the timeout from the message length, floored at the previous three seconds and capped at fifteen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toastMs()toadmin-logic.js: 60ms per character, floored at 3000ms and capped at 15000ms, with a non-string message treated as empty.admin-shared.jsinstead of the fixed 3000ms.Testing
All green. Added 1 test covering the floor, the cap, the per-character scale and a non-string message.
Checklist