Repository navigation
Improve: count work instead of time in speed tests and keep tests off real DNS - #581
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lateston mockedsetTimeoutandDateinstead of a 20 ms wall-clock bound.test-support/no-such-host.js, which answers every lookup with ENOTFOUND, and use it in the four tests that looked up nonexistent names over real DNS.pingUncheckedbefore resolving the host, so a refused URL makes no DNS query. Add a test for it.globalTimeouton the Playwright suite.Testing
All green. Each new count fails when its guard is removed. The backend suite passes with DNS answering nothing, apart from the resolver tests that start their own DNS server. The System Summary spec passed 50 of 50 runs in WebKit.
Changelog
Checklist