Skip to content

Fix: read the image's Node.js version from its binary and key the browser package cache on Playwright - #583

Merged
SandObserver merged 1 commit into
mainfrom
fix/ci-node-version-and-apt-cache
Oct 27, 2026
Merged

SandObserver merged 1 commit into
mainfrom
fix/ci-node-version-and-apt-cache

Conversation

@SandObserver

Copy link
Copy Markdown
Owner

Summary

  • Read the published image's Node.js version with docker run --platform "$PLATFORM" --entrypoint node ... -p process.versions.node in the scheduled scan. The FROM scratch runtime stage has no NODE_VERSION, so the old Config.Env read passed an empty string and failed every run once the image was latest.
  • Set up QEMU (same pinned action and binfmt image as the release workflow) for the arm64 run.
  • Key the e2e system-package cache on the runner image and the resolved Playwright version, and drop its restore key. A partial hit installed an older package set and skipped --with-deps.
  • Pin both in test/repo/release-workflow.test.js.

Testing
All green; the new version command returns 24.22.0 on the 1.19.0 image. Added 2 workflow tests.

Changelog

Checklist

  • Stays within the project constraints: one container, no runtime dependencies, no build step (see CONTRIBUTING.md).
  • Tests added or updated for new logic, and the full suite, lint, and typechecks pass.
  • Docs updated if behavior or configuration changed.

…package cache on Playwright

The runtime stage is FROM scratch and carries no NODE_VERSION, so the scheduled scan now runs the image's node under QEMU where needed. The e2e apt cache matches only the same runner image and Playwright version, with no partial restore.
@SandObserver SandObserver added the github_actions Pull requests that update GitHub Actions code label Oct 27, 2026
@SandObserver
SandObserver merged commit e86e197 into main Oct 27, 2026
5 of 6 checks passed
@SandObserver
SandObserver deleted the fix/ci-node-version-and-apt-cache branch October 27, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant