Skip to content

Security: send the PBS token over https and remove imported logins behind any slashes - #584

Merged
SandObserver merged 1 commit into
mainfrom
security/pbs-https-and-import-login
Oct 27, 2026
Merged

SandObserver merged 1 commit into
mainfrom
security/pbs-https-and-import-login

Conversation

@SandObserver

Copy link
Copy Markdown
Owner

Summary

  • Default a Proxmox Backup Server address with no scheme to https:// in pbsConn. dupNormalizeBase added http://, so the PBSAPIToken header crossed the network in clear text before the request failed.
  • Strip a login from an imported link by parsing it with URL and clearing username and password, in place of a pattern that required exactly //. http:/, http:///, http:\\ and http: links kept their credentials in the saved link and the health check address.
  • Match any run of slashes or backslashes after a web scheme when removing logins from preview text, and keep mailto: addresses intact.

Testing
All green. Added tests for the bare PBS address, the four slash forms and a mail link.

Changelog

Checklist

  • Stays within the project constraints: one container, no runtime dependencies, no build step (see CONTRIBUTING.md).
  • Tests added or updated for new logic, and the full suite, lint, and typechecks pass.
  • Docs updated if behavior or configuration changed.

…logins behind any slashes

A Proxmox Backup Server address with no scheme now gets https://. The importer parses each link as a browser does and clears its username and password, so one, three, back or no slashes no longer hide them.
@SandObserver SandObserver added the security Security fix label Oct 27, 2026
@SandObserver
SandObserver merged commit 2cb3cf0 into main Oct 27, 2026
6 checks passed
@SandObserver
SandObserver deleted the security/pbs-https-and-import-login branch October 27, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security Security fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant