Repository navigation
Security: send the PBS token over https and remove imported logins behind any slashes - #584
Merged
Merged
Conversation
…logins behind any slashes A Proxmox Backup Server address with no scheme now gets https://. The importer parses each link as a browser does and clears its username and password, so one, three, back or no slashes no longer hide them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://inpbsConn.dupNormalizeBaseaddedhttp://, so thePBSAPITokenheader crossed the network in clear text before the request failed.URLand clearingusernameandpassword, in place of a pattern that required exactly//.http:/,http:///,http:\\andhttp:links kept their credentials in the saved link and the health check address.mailto:addresses intact.Testing
All green. Added tests for the bare PBS address, the four slash forms and a mail link.
Changelog
Checklist