Repository navigation
Fix: name the Downloads finish day in the dashboard language - #585
Merged
Merged
Conversation
Move the finish-time formatting into belt-logic.js. The weekday and month follow the dashboard language; the 12- or 24-hour clock still follows the reader's locale. Remove the SABnzbd text check that a 200 reply could never reach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
navigator.language, as Up Next does. A Persian dashboard in an en-US browser showed an English weekday and month.finishPartsandreaderHourCycleinbelt-logic.js.api keytext check. SABnzbd answers a wrong key with 403, which the status check already reports, and a text 200 is refused beforedata.jssees it.Testing
All green. Added 2 tests for the finish time across languages and distances.
Changelog
Checklist