Repository navigation
Fix: keep Settings text fields at 16px or more on a sideways phone and read page zoom only at rest - #587
Merged
Conversation
…one, and read page zoom only at rest A sideways phone keeps the desktop Settings layout, so the small type step and the footnote-size header fields applied and iOS zoomed on focus. page-zoom.js reads the scale only while the visual viewport spans the layout width, so a rotation during a pinch is read when the pinch ends. The swatch spacing test runs at a phone width, where its rule still applies.
…-fields-and-pinch # Conflicts: # ui/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
html.type-small:not(.is-mobile)tokens in@media not all and (orientation:landscape) and (max-height:500px) and (pointer:coarse). A sideways phone keeps the desktop Settings layout, so every text field fell to 15px and iOS zoomed on focus.html.is-mobilealready does.page-zoom.jsonly whilevisualViewport.widthspans the layout width, and listen tovisualViewportresize, so turning the phone during a pinch no longer stores the pinch factor in--inset-scale.Testing
All green, including e2e; the swatch test fails at 18.8px with the old spacing rule. Added tests for both media rules and for turning the phone while pinched.
Changelog
Checklist