Skip to content

Fix: keep Settings text fields at 16px or more on a sideways phone and read page zoom only at rest - #587

Merged
SandObserver merged 2 commits into
mainfrom
fix/sideways-settings-fields-and-pinch
Oct 27, 2026
Merged

SandObserver merged 2 commits into
mainfrom
fix/sideways-settings-fields-and-pinch

Conversation

@SandObserver

Copy link
Copy Markdown
Owner

Summary

  • Keep the default type step on a sideways phone: wrap the html.type-small:not(.is-mobile) tokens in @media not all and (orientation:landscape) and (max-height:500px) and (pointer:coarse). A sideways phone keeps the desktop Settings layout, so every text field fell to 15px and iOS zoomed on focus.
  • Give the header key and value fields body size under the same sideways query, as html.is-mobile already does.
  • Read the page zoom in page-zoom.js only while visualViewport.width spans the layout width, and listen to visualViewport resize, so turning the phone during a pinch no longer stores the pinch factor in --inset-scale.
  • Run the swatch spacing test at 430 x 932 and assert the phone layout. At 744px the page now uses the desktop layout and the test passed without the rule it covers.

Testing
All green, including e2e; the swatch test fails at 18.8px with the old spacing rule. Added tests for both media rules and for turning the phone while pinched.

Changelog

Checklist

  • Stays within the project constraints: one container, no runtime dependencies, no build step (see CONTRIBUTING.md).
  • Tests added or updated for new logic, and the full suite, lint, and typechecks pass.
  • Docs updated if behavior or configuration changed.

…one, and read page zoom only at rest

A sideways phone keeps the desktop Settings layout, so the small type step and the footnote-size header fields applied and iOS zoomed on focus. page-zoom.js reads the scale only while the visual viewport spans the layout width, so a rotation during a pinch is read when the pinch ends. The swatch spacing test runs at a phone width, where its rule still applies.
@SandObserver SandObserver added the ui/ux UI, UX, and accessibility only fix label Oct 27, 2026
…-fields-and-pinch

# Conflicts:
#	ui/index.html
@SandObserver
SandObserver merged commit e6f82ee into main Oct 27, 2026
6 checks passed
@SandObserver
SandObserver deleted the fix/sideways-settings-fields-and-pinch branch October 27, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui/ux UI, UX, and accessibility only fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant