Skip to content

Fix: keep the backup placeholder stable on hover #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SandObserver merged 1 commit into from
Aug 13, 2026
Merged

Fix: keep the backup placeholder stable on hover #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- A long error in Admin now stays on screen long enough to read, up to fifteen
seconds.
- Backup placeholder no longer moves or reshuffles when a card is hovered or
tapped.

## [1.6.0] - 2026-08-13

Expand Down
23 changes: 14 additions & 9 deletions ui/widgets/backup/backup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@
}

/* ── Canvas placeholder drawing ── */
function drawPh(canvas, haiku, isFront) {
function drawPh(canvas, haiku, isFront, seed) {
const dpr = Math.min(window.devicePixelRatio || 1, 2); /* cap DPR at 2 */
const W = canvas.offsetWidth;
const H = canvas.offsetHeight;
Expand All @@ -204,7 +204,9 @@
ctx.scale(dpr, dpr);
ctx.clearRect(0, 0, W, H);

const rng = Math.random.bind(Math);
/* Both faces of a card must draw the same pattern, and a redraw must repeat
it. Never use Math.random here. */
const rng = mkRng(seed);

/* Colors */
const dotC = isFront ? 'rgba(0,0,0,0.08)' : 'rgba(255,255,255,0.35)';
Expand Down Expand Up @@ -302,13 +304,13 @@

/* Draw once the canvas has a real size. A card whose height comes from
aspect-ratio layout has no size at draw time. */
function observeDraw(canvas, haiku, isFront) {
function observeDraw(canvas, haiku, isFront, seed) {
let lastW = 0, lastH = 0;
const ro = new ResizeObserver(() => {
const w = canvas.offsetWidth, h = canvas.offsetHeight;
if (!w || !h || (w === lastW && h === lastH)) return;
lastW = w; lastH = h;
drawPh(canvas, haiku, isFront);
drawPh(canvas, haiku, isFront, seed);
});
ro.observe(canvas);
}
Expand Down Expand Up @@ -470,7 +472,10 @@
back.className = 'card-back'; back.id = `back-${idx}`;

const backCanvas = document.createElement('canvas');
if (isMobile) backCanvas.style.height = 'calc(100% - 100px)';
/* Same height as the front canvas. A different height changes the row plan
and the placeholder moves when the card is hovered. The name zone is
opaque and covers the extra rows. */
if (isMobile) backCanvas.style.height = 'calc(100% - 48px)';
back.appendChild(backCanvas);
const backZone = document.createElement('div');
backZone.className = 'card-name-zone';
Expand Down Expand Up @@ -511,11 +516,11 @@
wrap.append(back, front);
w.appendChild(wrap);

_canvases[idx] = { front: frontCanvas, back: backCanvas, haiku };
_canvases[idx] = { front: frontCanvas, back: backCanvas, haiku, seed };

/* Draw when each canvas actually has its size (and redraw on real resize) */
observeDraw(frontCanvas, haiku, true);
observeDraw(backCanvas, haiku, false);
observeDraw(frontCanvas, haiku, true, seed);
observeDraw(backCanvas, haiku, false, seed);
});

}
Expand Down Expand Up @@ -558,7 +563,7 @@
/* Redraw back canvas with updated text color when status changes */
const c = _canvases[idx];
if (c && c.back.offsetWidth && c.back.offsetHeight) {
drawPh(c.back, c.haiku, false);
drawPh(c.back, c.haiku, false, c.seed);
}

if(bname) bname.textContent = job.name||'—';
Expand Down
Loading