Skip to content

Fix: pass the VEX image address without the registry scheme #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SandObserver merged 1 commit into from
Oct 27, 2026
Merged

Fix: pass the VEX image address without the registry scheme #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/vex.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
--file "/vex/stackyard-$arch.vex.json" \
--predicate-type https://openvex.dev/ns/v0.2.0 \
--referrer \
"registry://${IMAGE#docker.io/}@$(cat "$RUNNER_TEMP/digest-$arch")"
"${IMAGE}@$(cat "$RUNNER_TEMP/digest-$arch")"
done
env:
# Pin by digest. This program holds the Docker Hub token.
Expand Down
2 changes: 2 additions & 0 deletions test/repo/release-workflow.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,8 @@ test('the Scout program is pinned by digest and attaches by referrer', () => {
assert.match(attach.env.SCOUT_IMAGE, /^docker\.io\/docker\/scout-cli:[\d.]+@sha256:[0-9a-f]{64}$/);
assert.match(attach.run, /--referrer\b/, 'attaching into the index changes the signed digest');
assert.match(attach.run, /--org "\$NAMESPACE"/, 'Scout refuses to attach without the organisation');
assert.match(attach.run, /"\$\{IMAGE\}@\$\(cat "\$RUNNER_TEMP\/digest-\$arch"\)"/);
assert.doesNotMatch(attach.run, /registry:\/\//, 'attestation add reads the scheme as a host name');
assert.match(attach.run, /--predicate-type https:\/\/openvex\.dev\/ns\/v0\.2\.0/);
assert.match(attach.run, /--file "\/vex\/stackyard-\$arch\.vex\.json"/);
assert.match(vexStep('Prepare the VEX statements').run, /"\$RUNNER_TEMP\/stackyard-\$arch\.vex\.json"/);
Expand Down
Loading