Repository navigation
Security: cap request bodies on the sign-in and password routes - #606
Merged
Merged
Conversation
The login, set-password and toggle routes read up to the general 1 MB body limit before any session check. Parallel large bodies could exhaust the API's memory. nginx and the API now both refuse auth bodies above 32 KB.
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AUTH_BODY_LIMIT(32 KB) inapi/src/router.jsand letreadBodytake a per-route limit.login,set-passwordandtogglebodies withAUTH_BODY_LIMITinstead of the general 2 MB limit. An oversized body gets 400 from the API.location ^~ /api/auth/withclient_max_body_size 32k, so oversized auth bodies get 413 before they reach the API.Testing
All green. Added 5 tests: an oversized body on login, set-password and toggle gets 400, the largest real body still fits, and the nginx limit matches
AUTH_BODY_LIMIT.Changelog
Security
Checklist