Repository navigation
Fix: resolve showIf per field, not per key - #61
Merged
Merged
Conversation
SandObserver
force-pushed
the
fix/duplicate-field-keys-showif
branch
from
August 13, 2026 05:44
e7696e3 to
f70e02f
Compare
Two fields may share a key, one per branch of a showIf. Resolving visibility by key gave both the same answer, so the backup widget showed the Duplicati job picker alongside the Kopia one, and showed no picker at all for Duplicati. Add visibleFieldFlags, which answers by position, and apply it to the rendered rows by index.
SandObserver
force-pushed
the
fix/duplicate-field-keys-showif
branch
from
August 13, 2026 05:46
f70e02f to
aa41b1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visibleFieldFlags, which resolves each field'sshowIfby its position and returns one flag per field, and keepvisibleFieldKeysas a wrapper over it.showIfdependency against every field carrying the named key, so a duplicated controller key still gates its dependants._wireShowIf, instead of looking each row up by field key.Testing
All green, including the homelab Docker build. Added 1 test for branch fields sharing a key, and updated the source-shape assertion that pinned the old lookup.
Checklist