Repository navigation
Fix: tone a settings Fetch failure like a badge test - #63
Merged
Merged
Conversation
A widget settings Fetch painted every failure red, including a block that one setting allows. Return the tone alongside the message and apply it. Add a warning colour token and use it for both, replacing the badge path's hardcoded hex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optionsErrorTextwithoptionsErrorAdvice, returning{ tone, message }in the same shape asbadgeErrorAdvice, so the two paths cannot disagree about a failure..row-status.warnrule.--warningtoken and use it for the badge status too, replacing the hardcoded#ff9f0a/#ff453apair, which did not follow the increased-contrast palette in dark mode.Testing
All green, including the homelab Docker build. Added 1 assertion pair for the Fetch tone and moved the existing
optionsErrorTexttests onto the new return shape.Checklist