Skip to content

Fix: tone a settings Fetch failure like a badge test - #63

Merged
SandObserver merged 2 commits into
mainfrom
fix/settings-fetch-warning-tone
Aug 13, 2026
Merged

SandObserver merged 2 commits into
mainfrom
fix/settings-fetch-warning-tone

Conversation

@SandObserver

Copy link
Copy Markdown
Owner

Summary

  • Replace optionsErrorText with optionsErrorAdvice, returning { tone, message } in the same shape as badgeErrorAdvice, so the two paths cannot disagree about a failure.
  • Apply the tone to the Fetch status row in both the select and picklist controls, adding a .row-status.warn rule.
  • Add a --warning token and use it for the badge status too, replacing the hardcoded #ff9f0a / #ff453a pair, which did not follow the increased-contrast palette in dark mode.

Testing
All green, including the homelab Docker build. Added 1 assertion pair for the Fetch tone and moved the existing optionsErrorText tests onto the new return shape.

Checklist

  • Stays within the project constraints: one container, no runtime dependencies, no build step (see CONTRIBUTING.md).
  • Tests added or updated for new logic, and the full suite, lint, and typechecks pass.
  • Docs updated if behavior or configuration changed.
  • CHANGELOG.md updated under Unreleased if the change is user-visible.

A widget settings Fetch painted every failure red, including a block that
one setting allows. Return the tone alongside the message and apply it.

Add a warning colour token and use it for both, replacing the badge
path's hardcoded hex.
@SandObserver SandObserver added bug Something isn't working ui/ux UI, UX, and accessibility only fix labels Aug 13, 2026
@SandObserver
SandObserver merged commit 9146c47 into main Aug 13, 2026
4 checks passed
@SandObserver
SandObserver deleted the fix/settings-fetch-warning-tone branch August 13, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ui/ux UI, UX, and accessibility only fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant