Repository navigation
Fix: read a JSON field named count in a badge extract path - #65
Merged
Merged
Conversation
The extractor treated a path segment of `count` as the array-length token
wherever it appeared, so a badge pointed at a body such as {"count": 99}
resolved to zero. Only $count is the token unconditionally now; `count`
counts an array and otherwise reads the field.
SandObserver
force-pushed
the
fix/badge-extract-count-field
branch
from
August 14, 2026 20:46
8018088 to
fe1fcf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$countas the array-length token unconditionally, andcountas the token only when the current value is an array.countsegment on an object, so a badge pointed at a body such as{"count": 99}returns 99 instead of 0.Testing
All green, except the Docker build smoke test, which has no local Docker and is left to CI. Added 1 test covering a
countfield on an object and throughcomputeBadgeValue.Checklist